Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pipenv): Support custom environment variable usage in Pipfile source URLs #28062

Conversation

fivetide
Copy link
Contributor

Changes

This change expands functionality of pipenv to allow for arbitrary credential placeholders as outlined in discussion #26447.
In addition, multiple source-urls can now be handled.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title feat(26447): Support custom environment variable usage in Pipfile source URLs feat(manager.pipenv): Support custom environment variable usage in Pipfile source URLs Mar 21, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetide thank you for this PR!

I found the logic flow a little hard to follow, and think this will be a little hard to maintain. I know you're mostly just extending the existing flow, but the additional complexity has now increased an existing problem of it being hard to understand.

Would you mind adding some comments to the flow so that it's easier to follow and for future maintainers? Sometimes improved variable names make commenting unnecessary too.

Once you're done with that, I'll see if there's anything I can add myself

@viceice viceice changed the title feat(manager.pipenv): Support custom environment variable usage in Pipfile source URLs feat(manager/pipenv): Support custom environment variable usage in Pipfile source URLs Mar 22, 2024
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
@fivetide fivetide requested a review from rarkins April 2, 2024 08:30
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/pipenv/artifacts.ts Outdated Show resolved Hide resolved
rarkins and others added 5 commits April 13, 2024 10:58
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice April 23, 2024 09:30
fivetide and others added 3 commits April 23, 2024 16:10
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins requested a review from viceice April 26, 2024 17:56
@rarkins rarkins enabled auto-merge April 26, 2024 17:56
@rarkins
Copy link
Collaborator

rarkins commented Apr 28, 2024

@fivetide it's best that you don't merge from main unless it's to fix something. Otherwise it resets the tests and I need to manually approve it again. If/when @viceice it will start automerging, assuming tests have passed

@fivetide
Copy link
Contributor Author

Hey @rarkins, @viceice thanks for getting this PR ready. It looks to me that the merge is blocked by outdated changes. can you point me to how to resolve that?

@rarkins
Copy link
Collaborator

rarkins commented Apr 29, 2024

@fivetide it will now automerge once Michael approves

@rarkins rarkins added this pull request to the merge queue Apr 29, 2024
@fivetide
Copy link
Contributor Author

Thanks a whole lot to you guys for helping me making this happen!

Merged via the queue into renovatebot:main with commit 6ae3818 Apr 29, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.327.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants