New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/pipenv): Support custom environment variable usage in Pipfile source URLs #28062
feat(manager/pipenv): Support custom environment variable usage in Pipfile source URLs #28062
Conversation
…iable-usage-in-Pipfile-source-URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetide thank you for this PR!
I found the logic flow a little hard to follow, and think this will be a little hard to maintain. I know you're mostly just extending the existing flow, but the additional complexity has now increased an existing problem of it being hard to understand.
Would you mind adding some comments to the flow so that it's easier to follow and for future maintainers? Sometimes improved variable names make commenting unnecessary too.
Once you're done with that, I'll see if there's anything I can add myself
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…iable-usage-in-Pipfile-source-URLs
…iable-usage-in-Pipfile-source-URLs
…iable-usage-in-Pipfile-source-URLs
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…iable-usage-in-Pipfile-source-URLs
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…iable-usage-in-Pipfile-source-URLs
…iable-usage-in-Pipfile-source-URLs
…iable-usage-in-Pipfile-source-URLs
@fivetide it will now automerge once Michael approves |
Thanks a whole lot to you guys for helping me making this happen! |
🎉 This PR is included in version 37.327.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This change expands functionality of pipenv to allow for arbitrary credential placeholders as outlined in discussion #26447.
In addition, multiple source-urls can now be handled.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: