Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct digest resolution when the replacementName and replacementVersion options are defined #27773

Closed

Conversation

ssegato81
Copy link
Contributor

Changes

  • getDigestConfig function now keeps the original package name and replacementVersion value
  • The function that gets the digest for the docker datasource takes into consideration what type of change is happening and uses the correct docker image name and version when the replacementName/replacementVersion values have been defined.

Context

Closes #20304

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ssegato81 ssegato81 changed the title Fixed how Renovate obtains Docker digest when the replacementName is … fix: Correct digest resolution when the replacementName and replacementVersion options are defined Mar 7, 2024
@rarkins rarkins added the auto:discussion-first This PR needs to be preceded by a GitHub Discussion label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Please create a GitHub Discussion before continuing with this PR.

Thank you for your PR, but we need to discuss the requirements and implementation first. This PR will be closed, but you can reopen it after the discussion has been resolved.

Thanks, the Renovate team

@github-actions github-actions bot closed this Mar 7, 2024
@rarkins
Copy link
Collaborator

rarkins commented Mar 7, 2024

Sorry, but this is not an acceptable approach and needs discussion first

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types should remain unchanged

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:discussion-first This PR needs to be preceded by a GitHub Discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker: Replacement causes existing dependencies to use wrong digest
2 participants