feat(fvm): Support v3 config file #27216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
1 task
viceice
reviewed
Feb 11, 2024
viceice
requested changes
Feb 11, 2024
| export function extractPackageFile( | ||
| content: string, | ||
| packageFile: string, | ||
| ): PackageFileContent | null { | ||
| let fvmConfig: FvmConfig; | ||
| let fvmConfig: any; |
There was a problem hiding this comment.
Sorry, can you elaborate? I have little experience Typescript and none with zod.
There was a problem hiding this comment.
There was a problem hiding this comment.
We also have some developer documentation for Zod here:
https://github.com/renovatebot/renovate/blob/main/docs/development/zod.md
secustor
requested changes
Feb 11, 2024
| @@ -6,6 +6,6 @@ export { extractPackageFile } from './extract'; | |||
| export const supportedDatasources = [FlutterVersionDatasource.id]; | |||
|
|
|||
| export const defaultConfig = { | |||
| fileMatch: ['(^|/)\\.fvm/fvm_config\\.json$'], | |||
| fileMatch: ['(^|/)\\.fvm(?:/fvm_config\\.json|rc)$'], | |||
There was a problem hiding this comment.
Split this in two different regexes for better readability:
Suggested change
| fileMatch: ['(^|/)\\.fvm(?:/fvm_config\\.json|rc)$'], | |
| fileMatch: [ | |
| '(^|/)\\.fvm/fvm_config\\.json$', | |
| '(^|/)\\.fvmrc$' | |
| ], |
| export function extractPackageFile( | ||
| content: string, | ||
| packageFile: string, | ||
| ): PackageFileContent | null { | ||
| let fvmConfig: FvmConfig; | ||
| let fvmConfig: any; |
There was a problem hiding this comment.
|
Sorry I didn't have the time to work on this. I will try to have a look again soon. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fvm v3 has a new config file at
.fvmrcand uses a slightly different syntax in the config file.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: