Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets)!: drop renovate.json fallback #23910

Closed
wants to merge 2 commits into from

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 17, 2023

Changes

Remove the fallback to renovate.json preset when default.json is not found.

NOTE: Review with ignore whitespace changes. 馃槈

TODO

  • fix conflicts
  • throw config error when fallback found

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the breaking Breaking change, requires major version bump label Aug 17, 2023
@viceice viceice mentioned this pull request Aug 17, 2023
5 tasks
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of coverage LGTM

Also not approving as it targeted at the main branch ;)

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabeelsaabna can you find out how many Fallback to renovate.json file as a preset is deprecated, please use a default.json file instead. log messages we see daily in the hosted app?

@viceice we may want to upgrade this to a WARN for a longer period of time first

@nabeelsaabna
Copy link
Contributor

nabeelsaabna commented Aug 30, 2023

@rarkins in the last 7 days we have 4234 unique repositories with this message in the github hosted app

@viceice
Copy link
Member Author

viceice commented Sep 6, 2023

ok I've created another PR to warn now, so we can drop later

@rarkins rarkins marked this pull request as draft September 6, 2023 11:23
@rarkins
Copy link
Collaborator

rarkins commented Sep 16, 2023

I don't think we can do this yet

@rarkins rarkins closed this Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
@viceice viceice mentioned this pull request Mar 18, 2024
22 tasks
@renovatebot renovatebot unlocked this conversation Mar 18, 2024
@viceice viceice reopened this Mar 18, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have too many still using this in the Renovate app.

@viceice
Copy link
Member Author

viceice commented Mar 18, 2024

I think we have too many still using this in the Renovate app.

so what's the next step to get existing users to change their settings?

@rarkins
Copy link
Collaborator

rarkins commented Mar 18, 2024

We could improve our efficiency by remembering these fallbacks in repositoryCache: #28008

@rarkins
Copy link
Collaborator

rarkins commented Apr 14, 2024

I'm not sure we can merge this for a long time, certainly not in v38. So let's close this PR but keep the branch in place

@rarkins rarkins closed this Apr 14, 2024
@rarkins rarkins deleted the feat/drop-preset-fallback branch April 22, 2024 05:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants