Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect range for vertical_zoom_factor (sample) #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Incorrect range for vertical_zoom_factor (sample) #145

wants to merge 1 commit into from

Conversation

snabeljoel
Copy link
Contributor

Renoise allows setting this value between 0.0 and 1.999... It was incorrectly specified as 0-1.

(The error message in Renoise is similarly incorrect)

Renoise allows setting this value between 0.0 and 1.999... It was incorrectly specified as 0-1.

(The error message in Renoise is similarly incorrect)
@bjorn-nesby
Copy link
Contributor

Hi, and sorry for the late response!
I just checked and nothing seems wrong. Renoise accepts a 0-1 range. Try setting it to something else and you will get the following error:

std::logic_error: 'invalid vertical_zoom_factor value '2'. valid values are (0 to 1).'

@snabeljoel
Copy link
Contributor Author

Try setting it to 1.99. Renoise accepts 0-1.999, but not 2... (hence why I wrote "-> [number >= 0.0 < 2.0]")

I think the commit is valid, but maybe you want to fix this in Renoise instead of updating the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants