Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Waveform visualization api #578

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Add Waveform visualization api #578

wants to merge 23 commits into from

Conversation

Iamshankhadeep
Copy link
Contributor

fixes #421.

@Iamshankhadeep Iamshankhadeep marked this pull request as draft September 5, 2021 16:58
@Iamshankhadeep Iamshankhadeep changed the title WIP: add Waveform visualization api Add Waveform visualization api Nov 22, 2021
@Iamshankhadeep Iamshankhadeep marked this pull request as ready for review November 30, 2021 18:37
@JonnyBurger
Copy link
Member

JonnyBurger commented Dec 4, 2021 •
edited

TODOs:

  • Added new createSmoothSvgPath API - need to document it
  • Update the Audio visualization page to mention the new API and give guidance on which API to choose for what (audio vs. music)
  • New normalize property was added to getWaveformPortion and not documented. Will result in type error for people who upgrade. What shall we do?
  • Better explain examples and maybe copy it over to the Audio visualization page
  • Insert new voiceover (I ordered from Fiverr)

@vercel
Copy link

vercel bot commented Jan 10, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

remotion – ./

🔍 Inspect: https://vercel.com/remotion/remotion/7phkxebT6tmhbUzebTBSt4oMrsEG
✅ Preview: Failed

@tomByrer
Copy link
Contributor

@Iamshankhadeep I'm about to dive into AudiVis for my next project; is this good to go, or is there some more work (API or otherwise) needed?

TIA :)

@vercel
Copy link

vercel bot commented May 27, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ❌ Failed (Inspect) Jul 11, 2022 at 3:57PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonnyBurger JonnyBurger Awaiting requested review from JonnyBurger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio wave visualization
3 participants
@Iamshankhadeep @JonnyBurger @tomByrer