Add support for HTTP2 pseudo headers #55
Conversation
Node internally uses undici instead anyway
🦋 Changeset detectedLatest commit: a423019 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
which begin with `:` e.g. `:authority`, `:method`, etc.
pcattori
force-pushed
the
pedro/pseudo-headers
branch
from
ee6c863
to
6e0c9d5
Compare
|
Want to to add a unit test alongside the |
|
|
||
| const validateHeaderName = typeof validators.validateHeaderName === 'function' ? | ||
| validators.validateHeaderName : |
There was a problem hiding this comment.
Do we know exactly what this used to do? Any chance we start inadvertently rejecting headers in the wild that use to be allowed by this?
There was a problem hiding this comment.
The http-based validateHeaderName (which is what validators.validateHeaderName is) looks the same as ours. The only difference now is the :
https://github.com/nodejs/node/blob/main/lib/_http_outgoing.js#L664-L668
https://github.com/nodejs/node/blob/main/lib/_http_common.js#L206-L214
|
@brophdawg11 good callout, just added a test. Fails before this change, passes now. |
No description provided.