Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing useRouteError import in loader docs #9425

Merged
merged 2 commits into from May 20, 2024

Conversation

krystof-k
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

Copy link

changeset-bot bot commented May 12, 2024

⚠️ No Changeset found

Latest commit: c4c0ebb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 12, 2024

Hi @krystof-k,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@krystof-k krystof-k marked this pull request as draft May 12, 2024 20:29
@brophdawg11
Copy link
Contributor

Thank you for the update - would you mind signing the CLA so we can merge this?

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@krystof-k
Copy link
Contributor Author

@brophdawg11 Done! Sorry, I wanted to adjust the description etc. and then mark as ready to review, but feel free to merge it.

@krystof-k krystof-k marked this pull request as ready for review May 20, 2024 14:24
@brophdawg11 brophdawg11 merged commit 58ac1e9 into remix-run:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants