Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint ignore patterns for vite #9095

Merged
merged 2 commits into from Mar 25, 2024
Merged

chore: fix eslint ignore patterns for vite #9095

merged 2 commits into from Mar 25, 2024

Conversation

lifeiscontent
Copy link
Contributor

Closes: #9068

  • Docs
  • Tests

Testing Strategy:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2024 •
edited

⚠️ No Changeset found

Latest commit: 6d25b5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lifeiscontent
Copy link
Contributor Author

@brophdawg11 here's the fixes we talked about earlier today 😄

brophdawg11
brophdawg11 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@brophdawg11 brophdawg11 merged commit fbb1a90 into remix-run:dev Mar 25, 2024
2 checks passed
brophdawg11 added a commit that referenced this pull request Mar 25, 2024
@brophdawg11
chore: fix eslint ignore patterns for vite
0d0e98a 
Cherry pick of fbb1a90 (#9095)
@lifeiscontent lifeiscontent deleted the chore/fix-eslint-ignore-patterns-for-vite branch March 25, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lifeiscontent @brophdawg11