Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly release to use pnpm since it checks out the dev branch #9075

Merged
merged 1 commit into from Mar 18, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Mar 18, 2024

It looks like your nightly releases broke with the pnpm switch. Since the nightly workflow runs on a cron job, it always uses the workflow file from main, even though it checks out the source code from dev - per this comment I found when I went to check out the workflow 馃ぃ

# HEADS UP! this "nightly" job will only ever run on the `main` branch due to it being a cron job,
# and the last commit on main will be what github shows as the trigger
# however in the checkout below we specify the `dev` branch, so all the scripts
# in this job will be ran from that, confusing i know, so in some cases we'll need to create
# multiple PRs when modifying nightly release processes

This copies the updated file from dev down to main and hopefully tonights nightly release will pass 馃

Copy link

changeset-bot bot commented Mar 18, 2024

鈿狅笍 No Changeset found

Latest commit: 7367899

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 merged commit db2e812 into main Mar 18, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-nightly-release branch March 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants