Fix SPA mode when single fetch is enabled #9063
Conversation
🦋 Changeset detectedLatest commit: 1037483 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
added
feat:routing
package:dev
feat:spa
| @@ -303,7 +303,8 @@ export async function generateEntry( | |||
| let defaultEntryClient = path.resolve(defaultsDirectory, "entry.client.tsx"); | |||
| let defaultEntryServer = path.resolve( | |||
| defaultsDirectory, | |||
| ctx?.remixConfig.ssr === false | |||
| ctx?.remixConfig.ssr === false && | |||
| ctx?.remixConfig.future.unstable_singleFetch !== true | |||
There was a problem hiding this comment.
Reveal the streaming entry.server in SPA mode when single fetch is enabled.
I wonder if there's any good way to detect if a user is currently using renderToString in their own entry.server and they flip on single fetch. From what I recall the error isn't super obvious and React sticks it in a <template> at the end of the HTML but no console errors get logged.
There was a problem hiding this comment.
@jacob-ebey is going to look into a check at built time for this using the entry.server AST (separate PR)
| @@ -469,7 +469,7 @@ export async function resolveConfig( | |||
| let pkgJson = await PackageJson.load(rootDirectory); | |||
| let deps = pkgJson.content.dependencies ?? {}; | |||
|
|
|||
| if (isSpaMode) { | |||
| if (isSpaMode && appConfig.future?.unstable_singleFetch != true) { | |||
There was a problem hiding this comment.
Default to the streaming entry server in SPA mode w/singleFetch if the user doesn't have an entry.server
github-actions
bot
added
the
awaiting release
We can't use
renderToStringwhen single fetch is enabled, so don't default to (or reveal)entry.server.spa.tsxin SPA mode if single fetch is enabled.I also removed the
entry.server.tsxfile fromtemplates/spasince there's no need for the user to customize it like there may be in non-SPA templates.