Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to make Vite the default #9017

Merged
merged 4 commits into from Mar 11, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Mar 8, 2024

This is a first pass across the docs to make Vite the new default. I've also updated the 30m tutorial and its template to Vite. Once this PR goes through, I'll update the rest of the templates and move Vite docs out of "Future", I just wanted to minimise conflicts while this gets reviewed.

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: cea4b07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

remix vite:build
```

| Flag | Description | Type | Default |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all vite configs? Should we link off to the source of truth docs for them here as well?

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work going through all this!

@markdalgleish markdalgleish merged commit ea795f9 into main Mar 11, 2024
2 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/vite-default-docs branch March 11, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants