Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run loaders below the boundary during partial hydration #11324

Merged
merged 1 commit into from Mar 5, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Mar 5, 2024

Came across this during the single fetch work, where if a child loader threw on SSR and bubbled to the parent, we'd see that the child route had a loader and no loaderData/errors on the client and think we needed to re-run it

Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 6388244

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 05588d2 into dev Mar 5, 2024
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/partial-hydration-error branch March 5, 2024 15:18
Copy link
Contributor

github-actions bot commented Mar 5, 2024

🤖 Hello there,

We just published version 6.22.3-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Mar 7, 2024

🤖 Hello there,

We just published version 6.22.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant