-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nprogress): Upgrade to latest remix version with vite #482
Conversation
CI seems to have a little problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think entry.client and entry.server files could be removed? They are the default ones.
@brookslybrand You were right, it's the |
Hmm, yeah, seems like something not playing well with the root eslint which is run in CI/CD. Running it locally it seems like the linting you added passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the linting stuff, @machour, this all looks good to me! Thanks so much for working on updating all this stuff
If you want to defer removing @remix-run/eslint-config
to a later PR I'd be fine with that
No description provided.