Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nprogress): Upgrade to latest remix version with vite #482

Merged
merged 12 commits into from
May 28, 2024

Conversation

machour
Copy link
Collaborator

@machour machour commented May 17, 2024

No description provided.

@machour
Copy link
Collaborator Author

machour commented May 17, 2024

CI seems to have a little problem

Copy link
Member

@sergiodxa sergiodxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think entry.client and entry.server files could be removed? They are the default ones.

.nvmrc Outdated Show resolved Hide resolved
@machour
Copy link
Collaborator Author

machour commented May 28, 2024

@brookslybrand You were right, it's the .eslintrc.cjs file presence that makes the CI fail.
It's the same one that gets installed by the template, ie, https://github.com/remix-run/remix/blob/main/templates/remix/.eslintrc.cjs

@brookslybrand
Copy link

@brookslybrand You were right, it's the .eslintrc.cjs file presence that makes the CI fail. It's the same one that gets installed by the template, ie, https://github.com/remix-run/remix/blob/main/templates/remix/.eslintrc.cjs

Hmm, yeah, seems like something not playing well with the root eslint which is run in CI/CD. Running it locally it seems like the linting you added passes

Copy link

@brookslybrand brookslybrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the linting stuff, @machour, this all looks good to me! Thanks so much for working on updating all this stuff

If you want to defer removing @remix-run/eslint-config to a later PR I'd be fine with that

@machour machour changed the title feat(nprogress): Upgrade to latest remix version with vite refactor(nprogress): Upgrade to latest remix version with vite May 28, 2024
@machour machour merged commit 5714ec1 into main May 28, 2024
1 check failed
@machour machour deleted the upgrade-nprogress branch May 28, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants