-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mux): Add Mux Video example #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋
Thank you so much for the contribution and sorry for the delays getting back to you.
I'd like to get this example merged, but I wonder if you could:
- upgrade the template to the Vite version (see the updated __template folder)
- remove tailwindcss usage (to keep the example minimalistic)
- drop the pricing part from the README, as a user interested in Mux will get all that info from the official website
Let me know if you have thoughts about this 🙏
Hey @machour! Thanks for the feedback. It's addressed. |
Ah linting errors. Taking a look... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Mehdi Achour <machour@gmail.com>
I'm seeing the same rule of hooks error. But only the first time we run into that page, and only if that page isn't the first page I visit on boot. Similarly, if the first page I visit is the I wonder if it's related to I don't know enough about vite or how it optimizes dependencies to be sure, though. Do you? |
I don't, and am suspecting the same thing as you since I've been seeing it on my own projects ! |
Ahoy! Adding a Mux Video example following a basic UGC upload workflow. You can see a similar flow implemented at https://stream.new.
Looking forward to any feedback, and looking forward to getting this example into the hands of Remix devs!