Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mux): Add Mux Video example #441

Merged
merged 10 commits into from
May 30, 2024
Merged

Conversation

decepulis
Copy link
Contributor

Ahoy! Adding a Mux Video example following a basic UGC upload workflow. You can see a similar flow implemented at https://stream.new.

Looking forward to any feedback, and looking forward to getting this example into the hands of Remix devs!

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thank you so much for the contribution and sorry for the delays getting back to you.

I'd like to get this example merged, but I wonder if you could:

  • upgrade the template to the Vite version (see the updated __template folder)
  • remove tailwindcss usage (to keep the example minimalistic)
  • drop the pricing part from the README, as a user interested in Mux will get all that info from the official website

Let me know if you have thoughts about this 🙏

@decepulis
Copy link
Contributor Author

Hey @machour! Thanks for the feedback. It's addressed.

@decepulis
Copy link
Contributor Author

Ah linting errors. Taking a look...

@machour machour self-requested a review May 30, 2024 14:39
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat work, thank you!

Just two little details in the README and we're good to go!

By the way, tested the example locally, uploaded a video, and when it was done, I had an error flash before the video got rendered. Are you getting the same thing? (I'll suspect my local env otherwise)

Screenshot 2024-05-30 at 3 38 30 PM

mux-video/README.md Outdated Show resolved Hide resolved
mux-video/README.md Outdated Show resolved Hide resolved
decepulis and others added 2 commits May 30, 2024 09:43
Co-authored-by: Mehdi Achour <machour@gmail.com>
@decepulis
Copy link
Contributor Author

I'm seeing the same rule of hooks error. But only the first time we run into that page, and only if that page isn't the first page I visit on boot. Similarly, if the first page I visit is the playback page, mux-player-react loads fine but mux-uploader-react throws a rule of hooks error. The errors go away after I hard reload the page, clearing the browser cache. The errors re-appear if I clear my node_modules and start again.

I wonder if it's related to [vite] ✨ new dependencies optimized: @mux/mux-player-react; I only notice the error before that happens.

I don't know enough about vite or how it optimizes dependencies to be sure, though. Do you?

@machour
Copy link
Collaborator

machour commented May 30, 2024

I don't, and am suspecting the same thing as you since I've been seeing it on my own projects !
So I don't think this is related to your PR, and that we can look the other way ^^

@machour machour changed the title Mux Video example feat(mux): Add Mux Video example May 30, 2024
@machour machour merged commit 5f04397 into remix-run:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants