Speed up bazaar by simulating bzr root with bash #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PS1 line took forever (~1s) to display in bzr branches, because bzr is slow. I increased the speed by eliminating the call to bzr, and replacing it with a modified bash script which I found here: http://unix.stackexchange.com/questions/6463/find-searching-in-parent-directories-instead-of-subdirectories
| bzr_root=${bzr_root%/*} | ||
| if [ "$bzr_root" = "" ]; then break; fi | ||
| done | ||
| base_dir=$bzr_root || return 1 |
There was a problem hiding this comment.
This line doesn't quite work yet. I haven't had time to fix it.
At the moment, this is a regression, because it shows (bzr) even when you are not a a bzr directory.
This is because $bzr_root can never return a non zero exit status, because it is not a function.
I don't know quite enough bash to fix this, and don't have time to learn at the moment.
The previous commit didn't know what to do outside of a bzr repo. This fixes it, and makes it a bit faster.
|
This version should work now. The bzr part should be a lot quicker too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PS1 line took forever (~1s) to display in bzr branches, because bzr is slow.
I increased the speed by eliminating the call to bzr, and replacing it with a modified bash script which I found here:
http://unix.stackexchange.com/questions/6463/find-searching-in-parent-directories-instead-of-subdirectories