android w/ ghc 8.10 #782
Draft
android w/ ghc 8.10 #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgibbard
reviewed
Jun 7, 2022
default.nix
Outdated
| @@ -1,6 +1,6 @@ | |||
| { nixpkgsFunc ? import ./nixpkgs | |||
| , system ? builtins.currentSystem | |||
| , config ? {} | |||
| , config ? { android_sdk.accept_license = true; } | |||
There was a problem hiding this comment.
probably not, but it was there when i got here
|
Overwriting the original Java sources, is exactly what I need. It worked immediately with this branch. well done. |
|
Currently it is not possible to upload an app to the google play store: I think it is not trivial to increase the android platform version to 30. |
There are changes in upstream's ghc-8.10 that aren't part of ghc-8.10.7 and this causes the nixpkgs to fail (because it tries to apply patches that have since been upstreamed)
…-8_10-wip * origin/nixpkgs-21.05: android: Update ghc thunk to one that actually includes splices
…-8_10-wip * origin/nixpkgs-21.05: android: sdk version 30
|
I overlooked, that in this MR some similar changes were done as in nixpkgs-22.05 , e.g. the gradle upgrade. How can we combine our efforts? |
…/reflex-platform into aliao/mobile-8_10-wip
…platform into aliao/mobile-8_10-wip
|
@mankyKitty is this already included in the v1 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just need a cheap & easy CI run