Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Any for serializer fn value annotation #2998

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

use Any for serializer fn value annotation #2998

wants to merge 1 commit into from

Conversation

benedikt-bartscher
Copy link
Contributor

Fixes issues with newer pyright versions

@masenf masenf marked this pull request as ready for review April 4, 2024 14:39
@masenf masenf marked this pull request as draft April 4, 2024 14:39
@masenf
Copy link
Collaborator

masenf commented Apr 4, 2024

Sorry accidentally marked this as ready.

I ran with the latest pyright and reflex has LOTS of issues 338 errors, 4 warnings, 0 informations 😢

@benedikt-bartscher
Copy link
Contributor Author

Yes, I know :(
But many of those issues do not arise if you use reflex in your project with a recent pyright version.
I wanted to address some of reflex's public apis to reduce the amount of type: ignore annotations in projects using reflex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benedikt-bartscher @masenf