Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlite3 gsub in Refinery::CmsGenerator #3530

Merged
merged 1 commit into from May 22, 2023
Merged

Fix sqlite3 gsub in Refinery::CmsGenerator #3530

merged 1 commit into from May 22, 2023

Conversation

parndt
Copy link
Member

@parndt parndt commented May 22, 2023

I noticed when running rails new -m https://www.refinerycms.com/t/edge
that it was mangling the Gemfile when the sqlite3 line looked like:

  gem 'sqlite3', '~> 1.4'

Instead of the expected:

  gem 'sqlite3'

Our gsub_file instruction now captures the entire line and inserts it
inside the group :development, :test do block.

@parndt parndt changed the title Fix sqlite3 gsub in Refinery::CmsGenerator Fix sqlite3 gsub in Refinery::CmsGenerator May 22, 2023
@parndt parndt merged commit 04f07c1 into main May 22, 2023
20 checks passed
@parndt parndt deleted the fix-sqlite3-gsub branch May 22, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant