Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify case-sensitive uniqueness for page part slug (fix Rails 6 deprecation warning) #3525

Merged
merged 2 commits into from Apr 23, 2023

Conversation

n7st
Copy link
Contributor

@n7st n7st commented Feb 17, 2023

Hi! We're seeing a deprecation warning for the uniqueness validator as of Rails 6. This pull request adjusts the validation in question to make it case sensitive, which was previously the default behaviour.

Here is the deprecation warning:

DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. To continue case sensitive comparison on the :slug attribute in Refinery::PagePart model, pass `case_sensitive: true` option explicitly to the uniqueness validator.

@parndt parndt enabled auto-merge (rebase) April 23, 2023 23:47
@parndt parndt merged commit 4930062 into refinery:main Apr 23, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants