Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Celery #3497

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Refactor Celery #3497

wants to merge 7 commits into from

Conversation

ilan-gold
Copy link
Member

@ilan-gold ilan-gold commented Nov 20, 2019 •
edited

This fixes #3473 and #2993.

  • We have removed the redundant AnalysisResult from the codebase, which fixes Analyses fail randomly due to IndexError #2993 (although it is not literally removed via a migration - we can do this though).
  • We now create the Node from the galaxy outputs at the same time as the output AnalysisNodeConnection objects within _galaxy_file_export and then _attach_workflow_outputs actually does just what it's name indicates - attaching the outputs, not creating them.
  • Prepare the stage for removing the annotation server as the function that calls the creation of the annotated nodes, _create_annotated_nodes, no longer runs auxiliary tasks. Thus auxiliary tasks can be run as the post-file-import task from the signal as we make the Node object before importing the file, which was preventing that from working previously.

@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited

Codecov Report

Merging #3497 into develop will decrease coverage by 0.47%.
The diff coverage is 86.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3497      +/-   ##
===========================================
- Coverage    87.83%   87.35%   -0.48%     
===========================================
  Files           96       96              
  Lines        16280    14835    -1445     
===========================================
- Hits         14299    12959    -1340     
+ Misses        1981     1876     -105
Impacted Files Coverage Δ
refinery/tool_manager/models.py 95.26% <100%> (-0.29%) ⬇️
refinery/tool_manager/tests.py 99.89% <100%> (-0.03%) ⬇️
refinery/core/test_models.py 98.88% <100%> (-0.45%) ⬇️
refinery/analysis_manager/tasks.py 71.37% <61.53%> (-2.95%) ⬇️
refinery/core/models.py 82.95% <87.5%> (-0.93%) ⬇️
refinery/data_set_manager/utils.py 81.27% <0%> (-0.58%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f8704...2b6dce3. Read the comment docs.

@ilan-gold ilan-gold requested review from hackdna and removed request for hackdna November 22, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackdna hackdna Awaiting requested review from hackdna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Celery and Analysis Handling Analyses fail randomly due to IndexError
1 participant
@ilan-gold