Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Celery and Analysis Handling #3473

Open
ilan-gold opened this issue Oct 22, 2019 · 0 comments · May be fixed by #3497
Open

Refactor Celery and Analysis Handling #3473

ilan-gold opened this issue Oct 22, 2019 · 0 comments · May be fixed by #3497
Assignees
Milestone

Comments

@ilan-gold
Copy link
Member

ilan-gold commented Oct 22, 2019

The code currently for handling the end of an Analysis is slow and redundant. It is requires rethinking how we handle the output from galaxy and how we create objects.

The work has already begun with fixing #3435 and #2642, but requires more, namely

  1. removing/refactoring redundant code
  2. refactoring tests (a big lift considering the amount of mocking going on)
  3. potentially altering the way in which we handle the tasks at the end
  4. using Node and not AnalysisResult to handle the post-analysis files - this will help resolve Analyses fail randomly due to IndexError #2993
  5. Add progress tracking for other stages beyond just the actual Analysis
@ilan-gold ilan-gold self-assigned this Oct 22, 2019
@ilan-gold ilan-gold changed the title Refactor The End fo Analysis (Download Metadata/Create Objects) Refactor Celery and Analysis Handling Nov 7, 2019
@ilan-gold ilan-gold linked a pull request Nov 20, 2019 that will close this issue
@ilan-gold ilan-gold modified the milestones: Release 1.7.3, Next Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant