Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): omit to parameter at root on unauthenticated redirects #5935

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented May 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

If user is not authenticated, <Authenticated /> redirects to the provided route and appends the current route to the to parameter. With this change, if the current route is the root (/), the to parameter will be omitted.

RK-642

@aliemir aliemir requested a review from a team as a code owner May 9, 2024 07:05
Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 9576c73

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 9, 2024

Deploy Preview for refine-video-club ready!

Name Link
🔨 Latest commit 9576c73
🔍 Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/663c759eb42bd60008e29e0f
😎 Deploy Preview https://deploy-preview-5935--refine-video-club.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented May 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9576c73. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 74 targets

Sent with 💌 from NxCloud.

Copy link

cypress bot commented May 9, 2024

Passing run #11050 ↗︎

0 378 33 0 Flakiness 0

Details:

Merge 9576c73 into 18b13d3...
Project: refine Commit: 9b5e872cab ℹ️
Status: Passed Duration: 22:38 💡
Started: May 9, 2024 7:13 AM Ended: May 9, 2024 7:36 AM

Review all test suite changes for PR #5935 ↗︎

@aliemir aliemir added this to the June Release milestone May 9, 2024
@aliemir aliemir changed the base branch from master to releases/june May 13, 2024 17:48
@aliemir aliemir merged commit 5e2e065 into releases/june May 13, 2024
98 checks passed
@aliemir aliemir deleted the refactor/do-not-append-route-if-root-when-unauthenticated branch May 13, 2024 17:48
@aliemir aliemir mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants