Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd): pin ant-design/icons dependency version #5934

Open
wants to merge 13 commits into
base: releases/june
Choose a base branch
from

Conversation

bombillazo
Copy link

@bombillazo bombillazo commented May 8, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

Re-add locking of "@ant-design/icons" to known working behavior

What is the new behavior?

Bypasses issue #5931

Notes for reviewers

@bombillazo bombillazo requested a review from a team as a code owner May 8, 2024 17:49
Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: a423ad4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@refinedev/live-previews Patch
@refinedev/inferencer Patch
@refinedev/antd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bombillazo bombillazo changed the title fix: lock antd-icons dependency version Lock ant-design/icons dependency version May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for refine-video-club failed.

Name Link
🔨 Latest commit c74e5d3
🔍 Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/6647ca6b91a3380008c99b4f

Copy link

nx-cloud bot commented May 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa74d6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@aliemir aliemir added this to the June Release milestone May 9, 2024
@BatuhanW BatuhanW changed the base branch from master to releases/june May 23, 2024 07:01
@BatuhanW
Copy link
Member

Hey @bombillazo can you do the changes for every occurence of this package? Also don't forget to do pnpm install after the changes, so pnpm-lock.yaml will also be updated. Also make sure to create patch changeset for affected packages.

@bombillazo bombillazo requested a review from a team as a code owner May 23, 2024 13:38
Copy link

netlify bot commented May 23, 2024

‼️ Deploy request for refine-crm rejected.

Name Link
🔨 Latest commit 0ce365b

@bombillazo
Copy link
Author

image

This error pops up after trying to update the branch

Copy link

cypress bot commented May 24, 2024

Passing run #11126 ↗︎

0 379 37 0 Flakiness 0

Details:

refactor(store): update store homepage and checkout design (#5960)
Project: refine Commit: d0ace600ba
Status: Passed Duration: 21:40 💡
Started: May 24, 2024 6:13 AM Ended: May 24, 2024 6:34 AM

Review all test suite changes for PR #5934 ↗︎

@aliemir
Copy link
Member

aliemir commented May 24, 2024

image

This error pops up after trying to update the branch

Hey @bombillazo, this is probably thrown because there are mismatching dependencies in examples etc. for @ant-design/icons. Can you try fixing the version for all occurrences and see if the issue persists? 🙏

@bombillazo
Copy link
Author

OK now its updated

@aliemir aliemir changed the title Lock ant-design/icons dependency version fix(antd): pin ant-design/icons dependency version May 24, 2024
.changeset/fast-bags-count.md Outdated Show resolved Hide resolved
@bombillazo bombillazo requested a review from BatuhanW May 24, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants