Ensure first field render gets initial value #4397
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #4304, #4344 and possibly other duplicates.
Since react-redux v6, a snapshot of the state is used each render in connected components instead of the store. This makes it impossible to initialize the form before the fields render. This fix simply passes the initial value as value when the form is uninitialized.
Also fixes a number of tests that required
Field
to be rendered twice initially. Most notably, "Field > should have value set to initial value on first render" actually checked if the field had an initial value on the second render 😄