New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sectionPrefix when using an empty name on a Field inside a FormSection #4118
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4118 +/- ##
======================================
Coverage 100% 100%
======================================
Files 72 72
Lines 1666 1666
======================================
Hits 1666 1666
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must include some tests.
Improving the docs would be good, but not a must IMO.
I'd worry about the |
Codecov Report
@@ Coverage Diff @@
## master #4118 +/- ##
======================================
Coverage 100% 100%
======================================
Files 74 72 -2
Lines 1694 1669 -25
======================================
- Hits 1694 1669 -25
Continue to review full report at Codecov.
|
@danielrob @gustavohenke I added the tests and handled the case |
I wonder if this should be documented somehow? Maybe a paragraph under |
Sorry, but you'll need to refactor this with the new context API. |
I found myself wanting a Field which, inside a
FormSection
would use the name passed to theFormSection
. For that, I tried passingname=''
, to no avail.This is useful if, like in my case, you want a text field to edit your whole section as JSON, while also having other fields editing different fields of the section: