[v24.1.x] [CORE-2814]: utils/file_io: fix double closing of ss::file in write_fully #18440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss::output_stream internally keeps track of in-flight exceptions. In the
close() method, it will close the underlying ss::file and rethrow the
exception.
ss::with_file_close_on_failure will too close the underlying ss::file if
the future fails, this can result in a double close triggering an
assertion like
```
seastar-prefix/src/seastar/include/seastar/core/future.hh:1917: future<T> seastar::promise<>::get_future() [T = void]: Assertion `!this->_future && this->_state && !this->_task' failed
```
This unit test shows how this assert could be triggered, if
ss::output_stream as an active exception:
```
SEASTAR_THREAD_TEST_CASE(test_with_file_close_on_failure) {
auto flags = ss::open_flags::rw | ss::open_flags::create
| ss::open_flags::truncate;
ss::with_file_close_on_failure(
ss::open_file_dma("/tmp/tmp.YuupbuphlR", flags),
[](ss::file f) mutable {
return f.close().then([] { throw "any value"; });
})
.get();
}
```
This commit moves out ss::output_stream::close() from
ss::with_file_close_on_failure.
The method is coroutinized for clarity.
(cherry picked from commit d83a6cf)
andijcr
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #18303
Fixes: #18439,