tests: wait for messages before adding a node to cluster #18426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `test_decommissioning_rebalancing_node` test case we check if a node that joined the cluster and have some partitions assigned to it in the process of data rebalancing can be successfully decommissioned. The test was flaky as sometimes all the partition rebalance actions were finished before we validated if rebalance started. Added a condition to make sure that we wait for more data before adding the node to cluster to make sure rebalance will last long enough for the decommission to interrupt it. Fixes: redpanda-data#13522 Signed-off-by: Michał Maślanka <michal@redpanda.com>
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49004#018f723c-ff83-4065-be71-29f5e8776b28 |
ztlpn
approved these changes
May 14, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
test_decommissioning_rebalancing_nodetest case we check if a node that joined the cluster and have some partitions assigned to it in the process of data rebalancing can be successfully decommissioned.The test was flaky as sometimes all the partition rebalance actions were finished before we validated if rebalance started.
Added a condition to make sure that we wait for more data before adding the node to cluster to make sure rebalance will last long enough for the decommission to interrupt it.
Fixes: #13522
Backports Required
Release Notes