Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues 2591 https://github.com/redis/redis-doc/issues/2591 #2592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issues 2591 https://github.com/redis/redis-doc/issues/2591 #2592

wants to merge 1 commit into from

Conversation

PansonPanson
Copy link

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 3, 2023

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f53b714

dwdougherty
dwdougherty approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwdougherty dwdougherty added the to-be-merged should probably be merged soon label Nov 7, 2023
zuiderkwast
zuiderkwast suggested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better English? I think the old text is fine and I don't see the benefit in changing it.

I think the documentation of this command should match DECR, INCR, INCRBY and INCRBYFLOAT. They all use a similar description.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dwdougherty
Copy link
Collaborator

The changes in this PR will be merged on the new docs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast requested changes

@dwdougherty dwdougherty dwdougherty approved these changes

Assignees
No one assigned
Labels
to-be-merged should probably be merged soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PansonPanson @CLAassistant @dwdougherty @zuiderkwast