New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: garbage collect images on Win32 backend #4662
base: master
Are you sure you want to change the base?
Conversation
@hiiamboris It still seems to be in conflict, could you please solve those? |
Sure |
OTOH, I don't see how this work is relevant to the new D2D backend. I see @qtxie considered freeing up image resources: red/runtime/platform/image-wic.reds Line 53 in 50d58d6
Line 244 in 50d58d6
But it doesn't seem to work. |
I think this PR might still be relevant. @qtxie what do you think? |
@hiiamboris OK. So you mark it by using |
@qtxie what comment? ;) |
@hiiamboris This one: red/runtime/platform/image-wic.reds Line 53 in 50d58d6
|
@qtxie but did you implement any part of GC support for images in D2D backend or not? |
@hiiamboris Nope. The same as the other platforms, no GC support for image was implemented. |
I thought it's supported on other platforms? |
Well, we certainly want it to be implemented. |
1ec06cd
to
7218fb4
Compare
@qtxie @dockimbel let's prioritize this. It's an absolute showstopper for real world apps, and seems like we're close to a solution from the above comments. |
What about the other backends? We need all the backends to support the same features. |
Since we're on to 1.0, this GC has no value anyway. #4837 |
The current GC is fine. See my detailed comments. |
Replaces #4300
see the description there