Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: garbage collect images on Win32 backend #4662

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hiiamboris
Copy link
Collaborator

Replaces #4300
see the description there

@dockimbel
Copy link
Member

@hiiamboris It still seems to be in conflict, could you please solve those?

@hiiamboris
Copy link
Collaborator Author

Sure

@hiiamboris
Copy link
Collaborator Author

OTOH, I don't see how this work is relevant to the new D2D backend.

I see @qtxie considered freeing up image resources:

; 2: if set, the image has been marked by the GC

#if any [OS = 'macOS OS = 'Linux OS = 'Windows][

But it doesn't seem to work.
I propose he finishes what he has planned.

@dockimbel
Copy link
Member

I think this PR might still be relevant. @qtxie what do you think?

@qtxie
Copy link
Contributor

qtxie commented May 5, 2021

@hiiamboris OK. So you mark it by using series/flags. You can remove the comment for img-node!.

@hiiamboris
Copy link
Collaborator Author

@qtxie what comment? ;)

@qtxie
Copy link
Contributor

qtxie commented May 6, 2021

@hiiamboris This one:

; 2: if set, the image has been marked by the GC

@hiiamboris
Copy link
Collaborator Author

@qtxie but did you implement any part of GC support for images in D2D backend or not?

@qtxie
Copy link
Contributor

qtxie commented May 7, 2021

@hiiamboris Nope. The same as the other platforms, no GC support for image was implemented.

@hiiamboris
Copy link
Collaborator Author

I thought it's supported on other platforms?

@greggirwin
Copy link
Contributor

Well, we certainly want it to be implemented.

@qtxie qtxie force-pushed the master branch 3 times, most recently from 1ec06cd to 7218fb4 Compare October 7, 2021 11:57
@greggirwin
Copy link
Contributor

@qtxie @dockimbel let's prioritize this. It's an absolute showstopper for real world apps, and seems like we're close to a solution from the above comments.

@dockimbel
Copy link
Member

"garbage collect images on Win32 backend"

What about the other backends? We need all the backends to support the same features.

@hiiamboris
Copy link
Collaborator Author

hiiamboris commented Aug 3, 2022

Since we're on to 1.0, this GC has no value anyway. #4837
Need a scalable realtime implementation built first.

@dockimbel
Copy link
Member

Since we're on to 1.0, this GC has no value anyway. #4837 Need a scalable realtime implementation built first.

The current GC is fine. See my detailed comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants