FIX: add scroller! for base #4648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbegin
force-pushed
the
basescroll
branch
from
6e040a0
to
47567a6
Compare
bitbegin
force-pushed
the
basescroll
branch
from
47567a6
to
f71c4d7
Compare
|
@qtxie Please review this PR. |
|
This is the internal used scroller object. It's only used in the rich-text for now (gui-console use it). I think it's better to review the design first before implement it for other faces. |
|
@qtxie So, should we close this PR until we complete the (re)design of the scroller face? |
|
@dockimbel It's fine to keep it open. |
qtxie
force-pushed
the
master
branch
3 times, most recently
from
1ec06cd
to
7218fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.