Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: divide crashlogs in two different forms for tvs and other devices #782

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IndusAryan
Copy link
Contributor

No description provided.

@IndusAryan IndusAryan marked this pull request as draft November 21, 2023 11:57
@IndusAryan
Copy link
Contributor Author

IndusAryan commented Nov 21, 2023

left the old form url for some reasons:

many crashes from different forks come there.

many crashes are already fixed but still recieved because people are using old versions.

rename old folder as legacy crashes.

so pls make 2 new forms and different folder and tell me here or private and i shall push a commit including the new urls.

@fire-light42
Copy link
Collaborator

@LagradOst

} else {
"FORM_URL_FOR_PHONES"
}

val data = mapOf(
"entry.1993829403" to errorContent.toJSON()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you checked that this key does not differ between forms?

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you checked that this key does not differ between forms?

hmm, found out that it won't be an issue because the form and its input data structure is same its just we have seperated their endpoint reciever url

@LagradOst
Copy link
Contributor

The crash report system has to be reworked entirely as google forms is a duck tape solution. If you poke at this I would suggest that you instead implement it as a real crash reporting system

@IndusAryan
Copy link
Contributor Author

IndusAryan commented Nov 22, 2023

The crash report system has to be reworked entirely as google forms is a duck tape solution. If you poke at this I would suggest that you instead implement it as a real crash reporting system

how and by reworking what??please tell steps of what needs to be ditched and cleaned up etc.

@LagradOst
Copy link
Contributor

The crash report system has to be reworked entirely as google forms is a duck tape solution. If you poke at this I would suggest that you instead implement it as a real crash reporting system

how and by reworking what??please tell steps of what needs to be ditched and cleaned up etc.

Instead of reporting to google forms (that just wont load after ~500k crash reports, and is super slow) we should instead use a real crash reporting site. I think saikou uses a more sophisticated crash reporting site, if you want to take a look at that.

@IndusAryan
Copy link
Contributor Author

IndusAryan commented Nov 23, 2023

I think saikou uses a more sophisticated crash reporting site

saikou and its popular fork Dantotsu uses google firebase analytics & crashlytics 👽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants