Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote sync #623

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

CranberrySoup
Copy link
Contributor

@CranberrySoup CranberrySoup commented Sep 22, 2023

Continuation of #442

  • Viewbindings
  • Add Pcloud
  • Add sync button
  • Add google drive profile info
  • Improve scheduler
  • Improve prompt and documentation (separate PR required)
  • Refactoring API
  • ???

Chiff and others added 30 commits April 3, 2023 21:43
…as really changed (true -> true is not a change)
Co-Authored-By: Martin Filo <10731497+chiff@users.noreply.github.com>
# Conflicts:
#	app/src/main/java/com/lagradost/cloudstream3/ui/player/GeneratorPlayer.kt
#	app/src/main/res/values/strings.xml
# Conflicts:
#	app/src/main/AndroidManifest.xml
@CranberrySoup
Copy link
Contributor Author

For anyone wondering whats happening: this is not dead, there is just some massive changes going on 👍

@CranberrySoup CranberrySoup marked this pull request as ready for review October 31, 2023 21:42
@CranberrySoup
Copy link
Contributor Author

This is now functional, but requires testing and better documentation.

@CranberrySoup CranberrySoup changed the title Remote sync draft Remote sync Oct 31, 2023
@Luna712
Copy link
Contributor

Luna712 commented Nov 1, 2023

This works pretty good now, the one thing I would suggest still is maybe some sort of prefill select to reuse keys from one Google Cloud Project when adding another account, chances are one Google Cloud Project can be used for all accounts using sync with.

@Luna712
Copy link
Contributor

Luna712 commented Nov 1, 2023

Also I wonder if we could hook Google accounts into the local account system to use Google accounts to save data to them, and have name/picture etc in account select for example, and show profile picture instead of the default account icon also. Could work for some data account provider, but is not needed for this PR I don't think, just a thought for later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in main not debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, thank you for finding this 👍

@TNTwise
Copy link

TNTwise commented Nov 30, 2023

After testing, I have found that if a file has been downloaded on a phone, and then is synced to a computer (or some other device), resume from the home menu doesn't work. Idk if this is a known issue, but I think its to do with this block of code located in

app/src/main/java/com/lagradost/cloudstream3/ui/search/SearchHelper.kt

if (card.isFromDownload) { handleDownloadClick( DownloadClickEvent( DOWNLOAD_ACTION_PLAY_FILE, VideoDownloadHelper.DownloadEpisodeCached( card.name, card.posterUrl, card.episode ?: 0, card.season, id, card.parentId ?: return, null, null, System.currentTimeMillis() ) ) ) } } else { loadSearchResult(card, START_ACTION_LOAD_EP, id)

Idk kotlin, or much about how cloudstream functions, but there might be a way to try catch this?

@KillerDogeEmpire
Copy link
Contributor

@CranberrySoup this dead?

@Luna712
Copy link
Contributor

Luna712 commented Mar 4, 2024

Any updates on this?

@Fruehwirth
Copy link

Hey. Just wondering how's it going with that PR? Any updates?

@Luna712 Luna712 mentioned this pull request Mar 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants