Fix unnecessary repetitions in the crowd #686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsid
reviewed
Jan 28, 2024
| @@ -163,9 +163,9 @@ int dtProximityGrid::queryItems(const float minx, const float miny, | |||
| // Item not found, add it. | |||
| if (i == end) | |||
| { | |||
| ids[n++] = item.id; | |||
There was a problem hiding this comment.
If maxIds is initially 0 and ids has 0 size (i.e. points to invalid memory) or nullptr this will lead to a crash due to nullptr dereference or out of bounds access.
ikpil
force-pushed
the
pr/avoid-unnecessary-repetitions
branch
2 times, most recently
from
af2d04e
to
8f8cc01
Compare
Maximum values should be checked after post-processing, as unnecessary repetitions may occur.
ikpil
force-pushed
the
pr/avoid-unnecessary-repetitions
branch
from
5376ca0
to
83e779e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximum values should be checked after post-processing, as unnecessary repetitions may occur.