Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve printing of destructuring with local open. #2684

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve printing of destructuring with local open. #2684

wants to merge 6 commits into from

Conversation

SanderSpies
Copy link
Contributor

Prints:

let EnterpriseContactForm.{
      personFirstNameField,
      personLastNameField,
      personEmailField,
      companyNameField,
      countryField,
      companySizeField,
      contactReasonField,
      submitFormState,
      onSubmit,
    } = formData;

as

let EnterpriseContactForm.{
 personFirstNameField,
 personLastNameField,
 personEmailField,
 companyNameField,
 countryField,
 companySizeField,
 contactReasonField,
 submitFormState,
 onSubmit,
} = formData;

instead.

See #2681.

SanderSpies and others added 6 commits February 24, 2023 19:01
@SanderSpies
Improve printing of destructuring with local open.
ab080d3
@SanderSpies
Add history.md entry.
60a3f17
@SanderSpies
Merge branch 'master' into sanderspies/fix_2681
14a92a9 
* master: (38 commits)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
  chore: update nix flake (reasonml#2692)
  chore(readme): clarify 3.9 is unreleased
  ...
@SanderSpies
add test
13004f2
@anmonteiro
Merge branch 'master' into sanderspies/fix_2681
288003d
@SanderSpies
Merge branch 'master' into sanderspies/fix_2681
5e5d22a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SanderSpies @anmonteiro