readyset-data: Integrate 'url' crate and refine authentication code #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbjuhasz
changed the title
readysetbot
force-pushed
the
Ic59d96884571accd19aaf13b8b8f51e20f97299b
branch
4 times, most recently
from
8cf9485
to
c6c5844
Compare
This commit addresses the following issues: - Included the 'url' crate in Cargo.toml - Adjusted the approach for processing user credentials from the upstream DB URL by using the 'url' crate to parse the URL and extract the username and password components. Change-Id: Ic59d96884571accd19aaf13b8b8f51e20f97299b
readysetbot
force-pushed
the
Ic59d96884571accd19aaf13b8b8f51e20f97299b
branch
from
c6c5844
to
804f3c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the following issues:
upstream DB URL by using the 'url' crate to parse the URL and extract
the username and password components.