system-benchmarks: Enable post-lookup support #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readysetbot
force-pushed
the
I1050e2df98a95a9d8c73c54b957ffd65e381b87b
branch
from
08ca53b
to
74328c0
Compare
readysetbot
force-pushed
the
Id5c964c8f332e2a52e3811848927b4b61f62ef11
branch
from
be3978f
to
0239854
Compare
readysetbot
force-pushed
the
I1050e2df98a95a9d8c73c54b957ffd65e381b87b
branch
from
74328c0
to
a44de3a
Compare
readysetbot
force-pushed
the
Id5c964c8f332e2a52e3811848927b4b61f62ef11
branch
from
0239854
to
41eddc7
Compare
Previously, our system benchmarks were running against Readyset with post-lookup disabled. This meant that any of our benchmarks that included queries that required post-lookup were actually proxying the workload upstream. This led to a large discrepancy in benchmark results between Postgres and MySQL due to Postgres handling certain aggregations more efficiently than MySQL. This commit fixes the issue by ensuring that our system benchmarks are running against a Readyset instance with post-lookups enabled. Change-Id: Id5c964c8f332e2a52e3811848927b4b61f62ef11
ethan-readyset
changed the base branch from
I1050e2df98a95a9d8c73c54b957ffd65e381b87b
to
main
readysetbot
force-pushed
the
Id5c964c8f332e2a52e3811848927b4b61f62ef11
branch
from
41eddc7
to
923b5d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our system benchmarks were running against Readyset with
post-lookup disabled. This meant that any of our benchmarks that
included queries that required post-lookup were actually proxying the
workload upstream. This led to a large discrepancy in benchmark results
between Postgres and MySQL due to Postgres handling certain aggregations
more efficiently than MySQL.
This commit fixes the issue by ensuring that our system benchmarks are
running against a Readyset instance with post-lookups enabled.