quickstart: Fix podman support #1227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our quickstart compose files were not working with `podman` because the literal `true` in yaml was being converted to a boolean value in Python instead of a string, which leads to env vars being set like `ENV_VAR=True`, since the Python literal for "true" is `True`. To fix this, this commit wraps the boolean literals in our compose files in quotes. Change-Id: I3ca1c9bc180e8df2a6cedf3f3208a34828939b35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our quickstart compose files were not working with
podmanbecause the literal
truein yaml was being converted to a booleanvalue in Python instead of a string, which leads to env vars being set
like
ENV_VAR=True, since the Python literal for "true" isTrue. Tofix this, this commit wraps the boolean literals in our compose files in
quotes.