util: Reduce number of proptest cases #1225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces the number of cases run in our readyset_util::fmt proptests from 1,000,000 to 10,000. The higher number of cases was substantially increasing the time the tests were taking to run in CI, and 10,000 should still give us good coverage. Change-Id: Ia457920d4187da0fe0fe9a38cb3f647c3bd86576 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7345 Reviewed-by: Jason Brown <jason.b@readyset.io> Tested-by: Buildkite CI
readysetbot
force-pushed
the
Ia457920d4187da0fe0fe9a38cb3f647c3bd86576
branch
from
28aac8f
to
0176879
Compare
ethan-readyset
changed the base branch from
I25938a3a549a28fc768a8b09f3d68a0327e1eb11
to
I4ed455df600ab0a2b022990c2933498e05310948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the number of cases run in our readyset_util::fmt
proptests from 1,000,000 to 10,000. The higher number of cases was
substantially increasing the time the tests were taking to run in CI,
and 10,000 should still give us good coverage.