Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/xml memleak fix #190

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature/xml memleak fix #190

wants to merge 4 commits into from

Conversation

Den271
Copy link

@Den271 Den271 commented Aug 22, 2015

PR for XML weak_ptr memory leak fix

  1. Started from develop branch, created feature/xml_memleak_fix branch
  2. in feature/xml_memleak_fix, Fixed VS2013 compilation errors
  3. in feature/xml_memleak_fix, Fixed ReadiumSDK code to be built with SDKLauncher-Win project
  4. in feature/xml_memleak_fix, Added the weak_pointer fix
  5. Created this Pull Request, base:develop compare:feature/xml_memleak_fix

please see the feature/xml_memleak_fix commit history
Note: it is compiled and tested on Windows&VS2013
I'm not sure it would compile ok for the other platforms, so please fix if required
Thanks

@danielweck
Copy link
Member

Reviewed. Looks fine to me, but I am not super-familiar with the logic that tracks XML node allocation, shared pointer, etc. So I guess the best way to test this PR is to open-close-open a number of EPUBs on iOS, Android and / or OSX, and profile / trace memory state. Unfortunately I don't think it is safe to assume that "if it works on platform-A, it should work on platform-B" (because of XML lib + WebView discrepancies?).

@danielweck
Copy link
Member

Also vcxproj question (which one to use from a launcher app's sln Visual Studio solution, ePub3 or ReadiumSDK?):

https://github.com/readium/readium-sdk/tree/feature/feature_revised_launcher/Platform/Windows

https://github.com/readium/SDKLauncher-Windows/tree/feature/feature_revised_launcher/SDKLauncher-Win

@danielweck
Copy link
Member

I commented here about separating the Windows-specific code changes (i.e. the memory leak fix should work in all platforms):
#191 (comment)

@rkwright
Copy link
Member

This is part of the work on Windows. As our support for Windows is up in the air, not sure what we will do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants