#54: Fix incorrect assertions for spine item references #107
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when generating package level CFI components.
|
At a glance, the code fixes look good to me. I have to look at usages of ConfirmOrCorrectSpineItemQualifier to have a better understanding of what it's for. Re. bookmarks: The ID assertion should only be used to double-check a spine item reference, the numerical step (even integer) should be used to actually resolve a reference. Need to check. |
|
I think the proposed code change is incomplete, see: #56 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #56 for details.
Note: This change might invalidate a user's saved bookmarks..