Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support TS 4.7+ node16 module mode #2645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Support TS 4.7+ node16 module mode #2645

wants to merge 1 commit into from

Conversation

rinsuki
Copy link

@rinsuki rinsuki commented Nov 10, 2022

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TypeScript 4.7+ introduces new module mode "node16" / "nodenext", it requires types field in package.json's exports field, not root.

see: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/

davidacevedo
davidacevedo approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@davidacevedo davidacevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidacevedo davidacevedo davidacevedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rinsuki @davidacevedo