Fix linter warnings

react-toolbox · Aug 7, 2016 · 77b0a4a · 77b0a4a
1 parent 25fd5e2
commit 77b0a4a
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 22 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -221,9 +221,7 @@
     "react/no-unknown-property": 1,
     "react/prop-types": [2, {"ignore": ["onMouseDown", "onTouchStart"]}],
     "react/react-in-jsx-scope": 1,
-    "react/require-extension": 1,
     "react/self-closing-comp": 1,
-    "react/sort-comp": 1,
-    "react/wrap-multilines": 1
+    "react/sort-comp": 1
   }
 }
diff --git a/.sass-lint.yml b/.sass-lint.yml
@@ -49,7 +49,6 @@ rules:
       convention: hyphenatedlowercase
   mixins-before-declarations: 0
   nesting-depth: 0
-  no-color-keyword: 1
   no-color-literals: 0
   no-css-comments: 1
   no-debug: 1
@@ -73,9 +72,6 @@ rules:
   no-trailing-zero: 1
   no-url-protocols: 1
   placeholder-in-extend: 0
-  placeholder-name-format:
-    - 0
-    - convention: hyphenatedlowercase
   property-sort-order:
     - 1
     - ignore-custom-properties: false

diff --git a/components/input/Input.js b/components/input/Input.js
@@ -177,7 +177,7 @@ const factory = (FontIcon) => {
         <div data-react-toolbox='input' className={className}>
           {React.createElement(multiline ? 'textarea' : 'input', inputElementProps)}
           {icon ? <FontIcon className={theme.icon} value={icon} /> : null}
-          <span className={theme.bar}></span>
+          <span className={theme.bar} />
           {labelText
             ? <label className={labelClassName}>
                 {labelText}

diff --git a/components/menu/Menu.js b/components/menu/Menu.js
@@ -206,7 +206,7 @@ const factory = (MenuItem) => {
 
       return (
         <div data-react-toolbox='menu' className={className} style={this.getRootStyle()}>
-          {this.props.outline ? <div className={theme.outline} style={outlineStyle}></div> : null}
+          {this.props.outline ? <div className={theme.outline} style={outlineStyle} /> : null}
           <ul ref='menu' className={theme.menuInner} style={this.getMenuStyle()}>
             {this.renderItems()}
           </ul>

diff --git a/components/progress_bar/ProgressBar.js b/components/progress_bar/ProgressBar.js
@@ -72,8 +72,8 @@ class ProgressBar extends Component {
     const {buffer, value} = this.linearStyle();
     return (
       <div>
-        <span ref='buffer' data-ref='buffer' className={this.props.theme.buffer} style={buffer}></span>
-        <span ref='value' data-ref='value' className={this.props.theme.value} style={value}></span>
+        <span ref='buffer' data-ref='buffer' className={this.props.theme.buffer} style={buffer}/>
+        <span ref='value' data-ref='value' className={this.props.theme.value} style={value}/>
       </div>
     );
   }

diff --git a/components/slider/Slider.js b/components/slider/Slider.js
@@ -281,7 +281,7 @@ const factory = (ProgressBar, Input) => {
               onTouchStart={this.handleTouchStart}
               style={knobStyles}
               >
-              <div className={theme.innerknob} data-value={parseInt(this.props.value)}></div>
+              <div className={theme.innerknob} data-value={parseInt(this.props.value)}/>
             </div>
 
             <div className={theme.progress}>

diff --git a/components/table/TableHead.js b/components/table/TableHead.js
@@ -16,7 +16,7 @@ const factory = (Checkbox) => {
       );
     } else if (selectable) {
       selectCell = (
-        <th key='select' className={theme.selectable}></th>
+        <th key='select' className={theme.selectable}/>
       );
     }
     return (

diff --git a/components/time_picker/ClockHand.js b/components/time_picker/ClockHand.js
@@ -116,7 +116,7 @@ class Hand extends Component {
 
     return (
       <div className={className} style={handStyle}>
-        <div ref='knob' className={theme.knob}></div>
+        <div ref='knob' className={theme.knob}/>
       </div>
     );
   }

diff --git a/components/tooltip/theme.scss b/components/tooltip/theme.scss
@@ -7,15 +7,15 @@
   position: absolute;
   z-index: $z-index-higher;
   display: block;
-  padding: $tooltip-margin;
   max-width: $tooltip-max-width;
+  padding: $tooltip-margin;
   font-family: Roboto, sans-serif;
   font-size: $tooltip-font-size;
   font-weight: $font-weight-bold;
   line-height: $font-size-small;
   text-align: center;
-  pointer-events: none;
   text-transform: none;
+  pointer-events: none;
   transition: $animation-curve-default $tooltip-animation-duration transform;
   transform: scale(0) translateX(-50%);
   transform-origin: top left;
@@ -47,9 +47,9 @@
 }
 
 .tooltipInner {
-  background: $tooltip-background;
-  border-radius: $tooltip-border-radius;
-  color: $tooltip-color;
   display: block;
   padding: $tooltip-padding;
+  color: $tooltip-color;
+  background: $tooltip-background;
+  border-radius: $tooltip-border-radius;
 }
diff --git a/docs/app/components/logo/index.js b/docs/app/components/logo/index.js
diff --git a/spec/components/card.js b/spec/components/card.js
@@ -143,7 +143,7 @@ const cards = {
         <CardMedia
           aspectRatio="wide"
         >
-          <iframe width="1280" height="720" src="https://www.youtube.com/embed/sGbxmsDFVnE?rel=0&amp;showinfo=0" frameBorder="0" allowFullScreen></iframe>
+          <iframe width="1280" height="720" src="https://www.youtube.com/embed/sGbxmsDFVnE?rel=0&amp;showinfo=0" frameBorder="0" allowFullScreen />
         </CardMedia>
         <CardActions style={{ justifyContent: 'flex-end' }}>
           <IconButton icon="report_problem" />