Enable an option to have empty tags #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp2hari
force-pushed
the
hari-empty_tag
branch
from
623df98
to
f133752
Compare
ad1992
requested changes
Oct 28, 2018
__tests__/reactTags.test.js
Outdated
| const $input = $el.find('.ReactTags__tagInputField'); | ||
| $input.simulate('change', { target: { value: '' } }); | ||
| $input.simulate('keyDown', { keyCode: ENTER_ARROW_KEY_CODE }); | ||
| if (allowEmpty) { |
There was a problem hiding this comment.
noooo lets not have if else conditions for assertions inside specs. This approach is fine when the assertions are exactly same. Please create two different specs
src/components/ReactTags.js
Outdated
| @@ -234,7 +236,7 @@ class ReactTags extends Component { | |||
| ? suggestions[selectedIndex] | |||
| : { id: query, [this.props.labelField]: query }; | |||
|
|
|||
| if (selectedQuery !== '') { | |||
| if (selectedQuery !== '' || this.props.allowEmpty === true) { | |||
There was a problem hiding this comment.
why this.props.allowEmpty === true, its anyways returning when allowEmpty is false
src/components/ReactTags.js
Outdated
| const { tags, labelField, allowUnique } = this.props; | ||
| if (!tag.id || !tag[labelField]) { | ||
| const { tags, labelField, allowUnique, allowEmpty } = this.props; | ||
| if ( (!tag.id || !tag[labelField]) && allowEmpty === false) { |
There was a problem hiding this comment.
instead of doing && here can we do early return when !allowEmpty ?
ad1992
requested changes
Oct 29, 2018
| const $input = $el.find('.ReactTags__tagInputField'); | ||
| $input.simulate('change', { target: { value: '' } }); | ||
| $input.simulate('keyDown', { keyCode: ENTER_ARROW_KEY_CODE }); | ||
| expect(actual).not.to.have.deep.members([{ |
There was a problem hiding this comment.
just checking the length of actual is zero should be enough here.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.