fix: setting headerBackTitleVisible to false not working on iOS #11937
Conversation
|
Hey @zetavg! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -182,6 +182,7 @@ export function HeaderConfig({ | |||
| backButtonInCustomView={backButtonInCustomView} | |||
| backgroundColor={headerBackgroundColor} | |||
| backTitle={headerBackTitleVisible ? headerBackTitle : ' '} | |||
There was a problem hiding this comment.
Should we still consider headerBackTitleVisible in backTitle, if we're passing backTitleVisible below? I believe the button will be hidden anyway.
There was a problem hiding this comment.
I think it's necessary for people who are using older versions of react-native-screens, since backTitleVisible is introduced in react-native-screens 3.21.0 and @react-navigation/native-stack has peer dependency of react-native-screens as >= 3.0.0.
(However, I haven't tested if only setting backTitleVisible will actually not work with react-native-screens <3.21.0 for now.)
I may need to add a "for backward competitivity" comment for this.
Motivation
According to the docs, setting
headerBackTitleVisibletofalseshould hide the back title on iOS, while this is not the case withreact-native-screensv3.29+.Cause
With the current code,
backTitle={headerBackTitleVisible ? headerBackTitle : ' '}, the back title is set to a blank string ifheaderBackTitleVisibleis false. However, in newer versions ofreact-native-screens, thebackTitlewill be considered blank if it only contains white spaces, making it fallback to the default title - which makes the back title not hidden at all.Fix
Assign the
backTitleVisibleproperty ofRNSScreenStackHeaderConfignative component, which seems to be a legit way to hide the back title.Test plan
backTitleVisiblescreen option set tofalse.react-native-screens.react-native-screens3.20.0and3.21.0, app does not crash and the back title remains hidden-able.