Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop unmountOnBlur in favor of popToTopOnBlur #11896

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satya164
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 77.11%. Comparing base (b1ed6b0) to head (4d84436).

Files Patch % Lines
packages/bottom-tabs/src/views/BottomTabView.tsx 55.55% 4 Missing ⚠️
packages/drawer/src/views/DrawerView.tsx 63.63% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11896      +/-   ##
==========================================
- Coverage   77.15%   77.11%   -0.05%     
==========================================
  Files         211      211              
  Lines        6278     6293      +15     
  Branches     2475     2477       +2     
==========================================
+ Hits         4844     4853       +9     
- Misses       1380     1386       +6     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 4d84436
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/65f4785482531a000862f56e
😎 Deploy Preview https://deploy-preview-11896--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evoactivity
Copy link

I use unmountOnBlur because my screens have a semi-transparent background (with BlurView on iOS) to allow a background video to be seen through my screen at all times. Without unmountOnBlur I can see my previous tabs through my current screen. Would this change preserve the behaviour of removing the blurred tabs from view?

@satya164
Copy link
Member Author

satya164 commented Apr 5, 2024

@evoactivity unmountOnBlur can easily be implemented in userland:

const isFocused = useIsFocused();

if (!isFocused) {
  return null;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants