Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for switch native driver usage in react native ta… #11866

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vibhor-d11
Copy link

@vibhor-d11 vibhor-d11 commented Mar 5, 2024

The following PR addresses the functionality to enable/disable the use of native driver for running animations for react-native-tab-view. For some specific devices the app crashes when native driver is enabled for android version 12 and above. So we have leveraged the useNativeDriver prop to make it configurable.

For more info please refer to the issue : Link

Copy link

github-actions bot commented Mar 5, 2024

Hey @vibhor-d11! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 49c260e
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/661d0e3025dde90008ccdbec
😎 Deploy Preview https://deploy-preview-11866--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.06%. Comparing base (dca15c9) to head (675e6fe).

Files Patch % Lines
.../material-top-tabs/src/views/MaterialTopTabBar.tsx 0.00% 1 Missing ⚠️
...material-top-tabs/src/views/MaterialTopTabView.tsx 0.00% 1 Missing ⚠️
...ges/react-native-tab-view/src/PagerViewAdapter.tsx 0.00% 1 Missing ⚠️
packages/react-native-tab-view/src/TabBar.tsx 0.00% 1 Missing ⚠️
packages/react-native-tab-view/src/TabView.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11866      +/-   ##
==========================================
- Coverage   77.12%   77.06%   -0.06%     
==========================================
  Files         208      208              
  Lines        6115     6122       +7     
  Branches     2399     2406       +7     
==========================================
+ Hits         4716     4718       +2     
- Misses       1345     1350       +5     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Have you opened an issue in react-native-pager-view and react-native repos?

And please provide more details about the problem such as which devices have such issues, error message or stack trace etc.

@vibhor-d11
Copy link
Author

vibhor-d11 commented Apr 15, 2024

Thanks for the PR. Have you opened an issue in react-native-pager-view and react-native repos?

And please provide more details about the problem such as which devices have such issues, error message or stack trace etc.

Hello @satya164

The issue is already raised in react native repro for this crash here Link. Will raise issue on react-native-pager-view also for the same.

You can refer to the issue for the stacktrace and more info. The issue was mainly on some android devices with android version 12.

@lucasoliveiraw00
Copy link

Obrigado pelo PR. Você abriu um problema react-native-pager-viewe react-nativerepositórios?

E forneça mais detalhes sobre o problema, como quais dispositivos apresentam esses problemas, mensagem de erro ou rastreamento de pilha, etc.

#11890 (comment)

@lucasoliveiraMM
Copy link

#11890 (comment)

@lucasoliveiraMM
Copy link

#11890 (comment)

@satya164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants