New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for switch native driver usage in react native ta… #11866
base: main
Are you sure you want to change the base?
feat: added support for switch native driver usage in react native ta… #11866
Conversation
Hey @vibhor-d11! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11866 +/- ##
==========================================
- Coverage 77.12% 77.06% -0.06%
==========================================
Files 208 208
Lines 6115 6122 +7
Branches 2399 2406 +7
==========================================
+ Hits 4716 4718 +2
- Misses 1345 1350 +5
Partials 54 54 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Have you opened an issue in react-native-pager-view
and react-native
repos?
And please provide more details about the problem such as which devices have such issues, error message or stack trace etc.
Hello @satya164 The issue is already raised in react native repro for this crash here Link. Will raise issue on You can refer to the issue for the stacktrace and more info. The issue was mainly on some android devices with android version 12. |
… material top tab
…b.com:vibhor-d11/react-navigation into feat/support-native-driver-switch-in-tab-view
|
The following PR addresses the functionality to enable/disable the use of native driver for running animations for react-native-tab-view. For some specific devices the app crashes when native driver is enabled for android version 12 and above. So we have leveraged the
useNativeDriver
prop to make it configurable.For more info please refer to the issue : Link