fix: Drawer on macos is registering clicks despite being inactive #11522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hsjoberg! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #11522 +/- ##
=======================================
Coverage 75.49% 75.49%
=======================================
Files 190 190
Lines 5742 5742
Branches 2261 2261
=======================================
Hits 4335 4335
Misses 1360 1360
Partials 47 47 ☔ View full report in Codecov by Sentry. |
osdnk
reviewed
Oct 31, 2023
satya164
requested changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey.
Motivation
If you use the drawer on react-native-macos, it will register click events even if the drawer is inactive, resulting in everything underneath the drawer being unclickable.
I suspect it's because of some
zIndexlayering issues (we set zIndex to -1 when inactive) going on, but not sure.This PR addresses this issue by setting
pointerEventsto"none"for react-native-macos.Test plan
Try @react-navigation/drawer@7.0.0-alpha.2 on react-native-macos old arch (could be the same on new arch, I don't know). Anything under where the drawer would be cannot be clicked on.
Note: react-reanimated broke its react-native-macos support >= 2.0, I have a pending fix for that here:
software-mansion/react-native-reanimated#4669
So either use react-reanimated 1 or use my fork:
"react-native-reanimated": "git+https://github.com/hsjoberg/react-native-reanimated.git#e998c740a083f075e6845a9ed1c81d5df1c220fc",