Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS,v6): support for form sheet medium detent #11516

Open
wants to merge 3 commits into
base: 6.x
Choose a base branch
from

Conversation

kkafar
Copy link
Contributor

@kkafar kkafar commented Aug 1, 2023

Motivation

WIP WIP

TODO:

  • Consult prop naming & API
  • Prepare PR for v7
  • Discuss upgrade of react-native-screens to 3.23.0 across repo

If this pull request addresses an existing issue, link to the issue. If an issue is not present, describe the issue here.

Test plan

WIP WIP

The change must pass lint, typescript and tests.

The question is: "do I have to?"

Should I bump screens version in `native-stack`, all packages or just
use `@tsignore`? Or maybe there is other mechanism of handling such
situations in use.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (c6fa588) 74.03% compared to head (56e4be9) 74.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##              6.x   #11516   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files         177      177           
  Lines        5630     5630           
  Branches     2214     2214           
=======================================
  Hits         4168     4168           
  Misses       1413     1413           
  Partials       49       49           
Files Changed Coverage Δ
.../native-stack/src/views/NativeStackView.native.tsx 78.94% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hadnet
Copy link

hadnet commented Aug 24, 2023

Is this feature gonna be available only in v7?

@kkafar
Copy link
Contributor Author

kkafar commented Aug 24, 2023

I aim to introduce it to v5, v6 and v7, however progress on this PR depends on software-mansion/react-native-screens#1852 which in turn waits for progress in Android modal implementation so I can create somewhat consistent API between two platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants