fix: bug with out of sync index in createMemoryHistory #11509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgrzybowski
force-pushed
the
fix-history-index
branch
from
c85f217
to
90c8f45
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11509 +/- ##
==========================================
- Coverage 75.72% 75.16% -0.56%
==========================================
Files 198 190 -8
Lines 5795 5747 -48
Branches 2268 2263 -5
==========================================
- Hits 4388 4320 -68
- Misses 1360 1380 +20
Partials 47 47
☔ View full report in Codecov by Sentry. |
satya164
requested changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request.
Motivation
The index in
createMemoryHistorymay be out of sync and that causes the items array to drop entries in some cases.Test plan
In example app, add this.log in onPopState callback, push many screens in simple stack, end up on Article screen, do one go back and one forward actions with browser buttons, click POP SCREEN . You will end up in the initial page instead of the previous screen you were at.
example.mov
The change must pass lint, typescript and tests.
Note
I've added a commit to log
createMemoryHistoryitems to make it easier to see what's actually going on. It can be removed before merging.To see the logs you have to uncomment the line 238 in
createMemoryHistory